Do not cache the classify_relation result #4870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4870 +/- ##
==========================================
- Coverage 90.97% 90.95% -0.03%
==========================================
Files 225 225
Lines 44244 44215 -29
==========================================
- Hits 40252 40215 -37
- Misses 3992 4000 +8
Continue to review full report at Codecov.
|
akuzm
commented
Oct 25, 2022
src/planner/planner.c
Outdated
Comment on lines
654
to
656
| * If parent reolid is know, the caller can specify it to avoid the costly | ||
| * lookup. Otherwise pass InvalidOid. |
There was a problem hiding this comment.
@jnidzwetzki This is the part that should improve planning performance
svenklemm
reviewed
Oct 25, 2022
src/planner/planner.c
Outdated
Comment on lines
654
to
656
| * If parent reolid is know, the caller can specify it to avoid the costly | ||
| * lookup. Otherwise pass InvalidOid. |
There was a problem hiding this comment.
Suggested change
| * If parent reolid is know, the caller can specify it to avoid the costly | |
| * lookup. Otherwise pass InvalidOid. | |
| * If parent reloid is known, the caller can specify it to avoid the costly | |
| * lookup. Otherwise pass InvalidOid. |
svenklemm
approved these changes
Oct 25, 2022
jnidzwetzki
approved these changes
Oct 26, 2022
It depends on the context, not only on the relation id. The same chunk can be expanded both as a child of hypertable and as an independent table.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It depends on the context, not only on the relation id. The same chunk can be expanded both as a child of hypertable and as an independent table.
Fixes #4708